Skip to content

Conversation

@keith
Copy link
Member

@keith keith commented Sep 18, 2025

This flag was added a few years ago and would be great to get out of
here. This is always surprising because it passes flags that aren't in
your crosstool.

@keith keith requested a review from lberki as a code owner September 18, 2025 19:34
@github-actions github-actions bot added team-Rules-ObjC Issues for Objective-C maintainers awaiting-review PR is awaiting review from an assigned reviewer labels Sep 18, 2025
@keith keith marked this pull request as draft September 18, 2025 19:35
This flag was added a few years ago and would be great to get out of
here. This is always surprising because it passes flags that aren't in
your crosstool.
@keith keith force-pushed the ks/flip-incompatible_avoid_hardcoded_objc_compilation_flags branch from d64682b to 40b043b Compare September 18, 2025 20:16
@keith keith marked this pull request as ready for review September 18, 2025 20:29
@keith
Copy link
Member Author

keith commented Sep 18, 2025

we can flip for 9.x and delete for 10.x

@keith
Copy link
Member Author

keith commented Oct 17, 2025

@trybka wdyt?

@pzembrod pzembrod removed the awaiting-review PR is awaiting review from an assigned reviewer label Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-Rules-ObjC Issues for Objective-C maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants